Date: Fri, 21 Oct 2011 17:51:18 -0700 From: Craig Rodrigues <rodrigc@crodrigues.org> To: David Wolfskill <david@catwhisker.org> Cc: freebsd-current@freebsd.org Subject: Re: sys/conf/newvers.sh vs. subversion-1.7 Message-ID: <CAG=rPVfD8EZYpD_SQES2%2B9uUeqGOaAhW3asJbVeGKeV3er2ZKw@mail.gmail.com> In-Reply-To: <20111021211221.GV59810@albert.catwhisker.org> References: <20111020114844.GK59810@albert.catwhisker.org> <20111020122121.GL59810@albert.catwhisker.org> <201110211636.05917.jhb@freebsd.org> <20111021211221.GV59810@albert.catwhisker.org>
index | next in thread | previous in thread | raw e-mail
Hi, Can you come up with a patch which invoke "svn info ." (if the svn binary exists)? This is slightly faster than svnversion. If "svn info ." doesn't error out, you can assume that the directory is under SVN control. -- Craig Rodrigues rodrigc@crodrigues.org On Fri, Oct 21, 2011 at 2:12 PM, David Wolfskill <david@catwhisker.org> wrote: > On Fri, Oct 21, 2011 at 04:36:05PM -0400, John Baldwin wrote: >> .... >> I'm not sure what the best fix is. One could possibly always run svnversion >> if it exists? > > Sure -- and use the result as long as the exit status is 0. (It's > certainly possible that svnversion exists, but the sources in question > aren't in a subversion working copy, after all.) > > I could cobble up a patch to do that, if y'all like.... > > Alternatively, see the more extended comments I made to Jilles' comments > (to the PR) of a similar nature; > <http://www.freebsd.org/cgi/query-pr.cgi?pr=161835>. Summary: I believe > that newvers.sh ought to be intrinsically SCM-agnostic. > > Peace, > david > -- > David H. Wolfskill david@catwhisker.org > Depriving a girl or boy of an opportunity for education is evil. > > See http://www.catwhisker.org/~david/publickey.gpg for my public key. > -- Craig Rodrigues rodrigc@crodrigues.orghelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVfD8EZYpD_SQES2%2B9uUeqGOaAhW3asJbVeGKeV3er2ZKw>