Date: Thu, 13 Dec 2012 18:12:42 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, jhb@freebsd.org Subject: Re: svn commit: r244154 - head/bin/ps Message-ID: <20121213161242.GE71906@kib.kiev.ua> In-Reply-To: <20121213111240.GB1381@garage.freebsd.pl> References: <201212121545.qBCFj4Hl086444@svn.freebsd.org> <20121212210652.GO3013@kib.kiev.ua> <20121213111240.GB1381@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--zjcmjzIkjQU2rmur Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > On Wed, Dec 12, 2012 at 03:45:04PM +0000, Pawel Jakub Dawidek wrote: > > > Author: pjd > > > Date: Wed Dec 12 15:45:03 2012 > > > New Revision: 244154 > > > URL: http://svnweb.freebsd.org/changeset/base/244154 > > >=20 > > > Log: > > > Use kern.max_pid sysctl to obtain maximum PID number instead of usi= ng local > > > define. > > It is pid_max, not max_pid. > >=20 > > But the change is wrong. The kern.pid_max only limits newly allocated p= ids, > > it does not magically moves existing pids, which are out of range, to t= he > > limited region. See the corresponding commit log for the description. > > It was added to make it easier to run FreeBSD 1.x binaries on the modern > > kernels. >=20 > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only... > How about defining BSD_PID_MAX in sys/proc.h, which would be visible by > userland as well and setting PID_MAX to BSD_PID_MAX? >=20 > This would also help bsnmpd. >=20 > http://people.freebsd.org/~pjd/patches/PID_MAX.patch Do you know why PID_MAX is under _KERNEL ? If there is no real reason, it would be better to move it outside kernel-only section. sys/proc.h is not in POSIX anyway. --zjcmjzIkjQU2rmur Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlDJ/noACgkQC3+MBN1Mb4j2ZgCeO92KcVRMVW2xcqobnFmWXwcN q2IAoM1XvZJdiTEAm9JwjQWk3epumwre =gZLA -----END PGP SIGNATURE----- --zjcmjzIkjQU2rmur--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121213161242.GE71906>