Date: Fri, 31 Dec 2010 17:54:23 -0600 From: Scot Hetzel <swhetzel@gmail.com> To: Chris Forgeron <cforgeron@acsi.ca> Cc: "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org> Subject: Re: ZFS v28 and zil_disable Message-ID: <AANLkTikRa%2Bfgf_xtbbEQbXp3UJo=wmW6_9W-rp1OJt2q@mail.gmail.com> In-Reply-To: <BEBC15BA440AB24484C067A3A9D38D7E0149F32D13D8@server7.acsi.ca> References: <BEBC15BA440AB24484C067A3A9D38D7E0149F32D13D8@server7.acsi.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 31, 2010 at 4:00 PM, Chris Forgeron <cforgeron@acsi.ca> wrote:
> BTW, I'm noticing the removal of vfs.zfs.zil_disable as well - It's not l=
isted as a sysctl when I check vfs.zfs, but I see it's still in the source =
code;
>
> In usr/src/sys/cddl/ :
> # grep -r zil_disable *
> cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zil.h.orig:extern int zil_=
disable;
> cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:int zil_disable =3D=
0; =A0 =A0 =A0/* disable intent logging */
> cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:TUNABLE_INT("vfs.zf=
s.zil_disable", &zil_disable);
> cddl/contrib/opensolaris/uts/common/fs/zfs/zil.c.orig:SYSCTL_INT(_vfs_zfs=
, OID_AUTO, zil_disable, CTLFLAG_RW, &zil_disable, 0,
> cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c.orig: =A0 if (zil=
_disable) {
> cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c.orig: =A0 =A0 =A0 =A0 i=
f (bp->bio_cmd =3D=3D BIO_FLUSH && !zil_disable)
>
>
All the files above show that the original files (*.orig) have the zil_disa=
ble.
Your grep of the sources shows that zil_disable was removed from
zil.h, zil.c, zfs_vfsops.c and zvol.c. I looked at pjd's perforce
repository and found that zil_disable was renamed to
zil_replay_disable.
Scot
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikRa%2Bfgf_xtbbEQbXp3UJo=wmW6_9W-rp1OJt2q>