Date: Tue, 16 Oct 2007 13:58:00 -0600 From: Scott Long <scottl@samsco.org> To: Roman Divacky <rdivacky@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.h Message-ID: <471517C8.9040505@samsco.org> In-Reply-To: <20071016085414.GA27376@freebsd.org> References: <200710122211.l9CMBM4J010733@repoman.freebsd.org> <20071016085414.GA27376@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Roman Divacky wrote: > On Fri, Oct 12, 2007 at 10:11:22PM +0000, Scott Long wrote: >> scottl 2007-10-12 22:11:22 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/cam/scsi scsi_all.h >> Log: >> Add a bunch of definitions and structures to support newer drivers. > > - page_start = (void *)((u_int8_t *)&mode_header[1] + > + page_start = (void *)((u_int8_t *)&mode_header[2] + > scsi_2btoul(mode_header->blk_desc_len)); > > are you sure this belongs here? > It's a minor bug fix that got grouped with the larger change. Are you upset that it wasn't clearly documented in the commit message, or are you pointing out that it's incorrect, or what? Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?471517C8.9040505>