Date: Tue, 30 Jan 2001 00:30:03 -0800 (PST) From: Peter Pentchev <roam@orbitel.bg> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/24707: [patch] Whois IP Address Handling Message-ID: <200101300830.f0U8U3A81441@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/24707; it has been noted by GNATS. From: Peter Pentchev <roam@orbitel.bg> To: Mike Barcroft <mike@coffee.q9media.com> Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/24707: [patch] Whois IP Address Handling Date: Tue, 30 Jan 2001 10:24:55 +0200 On Mon, Jan 29, 2001 at 11:31:26AM -0500, Mike Barcroft wrote: > > > Just a little comment - I think in checking for dotted-quad IP addresses > > you should be doing just that - check for dotted quads, not just check > > for a starting digit. Yes, I know that the RFC's forbid - or at least > > express a mild disagreement - with labels starting with a digit, but > > in the real world, your patch would break e.g. 'whois 42.com' :( > > Not true. The patch checks the TLD, so 42.com works and 10.0.0.0 goes to > ARIN. Since a TLD is never going to be a digit, it's safe to assume that > it's an IP address. Oops. You're right, sorry. I promise I'll actually read the code next time :) G'luck, Peter -- Do you think anybody has ever had *precisely this thought* before? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101300830.f0U8U3A81441>