Date: Tue, 21 Dec 2004 10:03:41 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jeremy Messenger <mezz7@cox.net> Cc: ports-committers@freebsd.org Subject: Re: cvs commit: ports/x11-themes/gtk-aluminumalloy-cryogenic-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-smog-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-toxic-theme pkg-plist ports/x11-themes/gtk-aluminumalloy-volcanic-theme pkg-plist Message-ID: <20041221100341.GA92486@FreeBSD.org> In-Reply-To: <opsjapvver9aq2h7@mezz.mezzweb.com> References: <200412200709.iBK79Q2n015446@repoman.freebsd.org> <opsjapvver9aq2h7@mezz.mezzweb.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 20, 2004 at 01:32:09AM -0600, Jeremy Messenger wrote:
>
> Why not depend on gtk and metacity? You can't use those theme without gtk
> and metacity. If you depend on those and you won't have that pkg-plist
> problem. Suggest to change like this:
>
> ==========================================
> .if ${TYPE} == "gtk"
> +USE_GNOME=gtk20
> THEME_DIR=${PREFIX}/share/themes/${THEME_NAME}
> PLIST_SUB+=GTK20=""
> PLIST_SUB+=METACITY="@comment "
> .else# metacity
> +USE_GNOME=metacity
> THEME_DIR=${PREFIX}/share/gnome/themes/${THEME_NAME}
> PLIST_SUB+=GTK20="@comment "
> PLIST_SUB+=METACITY=""
> .endif
> ==========================================
Hm.. I generally tend to not pulling in additional dependencies unless there is
an absolute need for doing so. But I'll condsider your suggestion, thanks!
>
> But, what if a user want to have both gtk and metacity?
There're corresponding metacity-* things exactly for that purpose.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041221100341.GA92486>