Date: Mon, 23 Jul 2001 18:41:08 +0200 From: Sheldon Hearn <sheldonh@starjuice.net> To: David Hill <david@phobia.ms> Cc: audit@freebsd.org Subject: Re: STD*_FILENO patches #2 Message-ID: <3804.995906468@axl.seasidesoftware.co.za> In-Reply-To: Your message of "Mon, 23 Jul 2001 12:25:35 -0400." <20010723122535.3cbd53ef.david@phobia.ms>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 23 Jul 2001 12:25:35 -0400, David Hill wrote: > NOTE: > pcvt - > header.h patch now contains #include <unistd.h> Wrong approach. Private (or local, or build-only) headers shouldn't be used to include all the crap that the source files that include them require. They should only include headers that are required for the things that they themselves declare and define. As an example/ pcvt's header.h includes <sgtty.h> so that the type "struct sgttyb" is available for the delcaration of sgttyOrg and sgttyNew. You should include <unistd.h> from the file that needs it; in this case, it's main.c . > window > #include <unistd.h> is in ww.h patch Probably the same problem here. Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3804.995906468>