Date: Tue, 25 Feb 2014 09:47:49 +0800 From: Julian Elischer <julian@freebsd.org> To: Andrew Turner <andrew@FreeBSD.org>, src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r262378 - projects/arm64/sys/boot/arm64/efi Message-ID: <530BF645.2000209@freebsd.org> In-Reply-To: <201402231844.s1NIiAkE072754@svn.freebsd.org> References: <201402231844.s1NIiAkE072754@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/24/14, 2:44 AM, Andrew Turner wrote: > Author: andrew > Date: Sun Feb 23 18:44:10 2014 > New Revision: 262378 > URL: http://svnweb.freebsd.org/changeset/base/262378 > > Log: > Use the stack provided by the UEFI firmware > > Modified: > projects/arm64/sys/boot/arm64/efi/start.S > > Modified: projects/arm64/sys/boot/arm64/efi/start.S > ============================================================================== > --- projects/arm64/sys/boot/arm64/efi/start.S Sun Feb 23 18:41:07 2014 (r262377) > +++ projects/arm64/sys/boot/arm64/efi/start.S Sun Feb 23 18:44:10 2014 (r262378) > @@ -137,12 +137,7 @@ section_table: > > .globl _start > _start: > - /* Set up the stack */ > - adr x29, init_stack > - mov x28, INIT_STACK_SIZE > - add x29, x29, x28 > - mov sp, x29 > - > + /* Save the boot params to the stack */ maybe you might add some information in a comment about how big the stack is, and what the UEFI spec says about it, > stp x0, x1, [sp, #-16]! > > adr x0, __bss_start >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?530BF645.2000209>