Date: Thu, 15 Nov 2012 15:25:35 -0500 From: Eitan Adler <eadler@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243095 - head/sys/dev/agp Message-ID: <CAF6rxgnECcfJUaq%2BaXv3YpUOVVErHoG20nnuvMCuo3gB7jPXBQ@mail.gmail.com> In-Reply-To: <20121115192255.GH73505@kib.kiev.ua> References: <201211151849.qAFInHeU039083@svn.freebsd.org> <20121115192255.GH73505@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 November 2012 14:22, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Thu, Nov 15, 2012 at 06:49:17PM +0000, Eitan Adler wrote: >> Author: eadler >> Date: Thu Nov 15 18:49:17 2012 >> New Revision: 243095 >> URL: http://svnweb.freebsd.org/changeset/base/243095 >> >> Log: >> Remove unneeded header from agp: opt_bus.h >> >> Tested with "make universe" > make universe cannot prove anything about usefulness of the removed include, > just because *_opt.h files contains only defines, which are used later > by the code like This is a good point. In this case I had done the manual review as well. "make universe" was an additional check. > If you are removing the option include, the module Makefile should be > adjusted too. :-\ I had sent this to Colin but forgot to include it in my final commit. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnECcfJUaq%2BaXv3YpUOVVErHoG20nnuvMCuo3gB7jPXBQ>