Date: Sun, 28 Aug 2005 00:07:45 +0300 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Andrew Thompson <thompsa@freebsd.org> Cc: Max Laier <max@love2party.net>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if_bridge.c Message-ID: <20050827210745.GC1208@gothmog.gr> In-Reply-To: <20050811225402.GA70630@heff.fud.org.nz> References: <200508112057.j7BKvxVs083144@repoman.freebsd.org> <200508120032.44995.max@love2party.net> <20050811225402.GA70630@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2005-08-12 10:54, Andrew Thompson <thompsa@freebsd.org> wrote: >>>> Use m_copypacket() which is an optimization of the common case >>>> m_copym(m, 0, M_COPYALL, how). >>>> >>>> This is required for strict alignment architectures where we align the >>>> IP header in the input path but m_copym() will create an unaligned copy >>>> in bridge_broadcast(). m_copypacket() preserves alignment of the first >>>> mbuf. >> >> I guess we should document this difference between m_copym and m_copypacket ?! > > It is in the comment block which is how I discovered it, but mbuf(9) is missing > the info about alignment. > > uipc_mbuf.c: > /* > * Copy an entire packet, including header (which must be present). [...] We should probably document it in the manpage too though. How about adding the same sentence to the ``Note:'' of m_copypacket() in mbuf.9?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050827210745.GC1208>