Date: Sun, 8 Sep 2013 18:24:56 +0200 From: Ed Schouten <ed@80386.nl> To: Davide Italiano <davide@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r255359 - in head/sys: cddl/dev/dtrace dev/firewire dev/vkbd security/audit Message-ID: <CAJOYFBAmmmd29N_W%2ByFK3m=z0otF47dWO2Kd4w42aQcCCt59bg@mail.gmail.com> In-Reply-To: <201309071345.r87Djj0P003439@svn.freebsd.org> References: <201309071345.r87Djj0P003439@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2013/9/7 Davide Italiano <davide@freebsd.org>:
> Log:
> - Use make_dev_credf(MAKEDEV_REF) instead of the race-prone make_dev()+
> dev_ref() in the clone handlers that still use it.
> - Don't set SI_CHEAPCLONE flag, it's not used anywhere neither in devfs
> (for anything real)
Wait. This piece of code is never used on FreeBSD HEAD, right? See
dtrace_load.c:
#if __FreeBSD_version < 800039
/* Enable device cloning. */
clone_setup(&dtrace_clones);
/* Setup device cloning events. */
eh_tag = EVENTHANDLER_REGISTER(dev_clone, dtrace_clone, 0,
1000);
#else
dtrace_dev = make_dev(&dtrace_cdevsw, 0, UID_ROOT, GID_WHEEL,
0600,
"dtrace/dtrace");
helper_dev = make_dev(&helper_cdevsw, 0, UID_ROOT, GID_WHEEL,
0660,
"dtrace/helper");
#endif
--
Ed Schouten <ed@80386.nl>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJOYFBAmmmd29N_W%2ByFK3m=z0otF47dWO2Kd4w42aQcCCt59bg>