Date: Sun, 8 Jun 2008 09:52:56 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Tim Kientzle <kientzle@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile Message-ID: <20080608075256.GA35560@obiwan.tataz.chchile.org> In-Reply-To: <200805261721.m4QHLCF4070787@repoman.freebsd.org> References: <200805261721.m4QHLCF4070787@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Tim, First of all, thanks for this work. It greatly contributes to the cleanness of the overall source tree :-). On Mon, May 26, 2008 at 05:21:12PM +0000, Tim Kientzle wrote: > kientzle 2008-05-26 17:21:12 UTC > > FreeBSD src repository > > Modified files: > gnu/usr.bin/cpio Makefile > Log: > Install GNU cpio as 'gcpio', symlink to 'cpio' unless WITH_BSDCPIO is > defined. There have been much work to glean all build flags over the source tree into a single place, namely src/share/bsd.own.mk. See [1]. I think it would be better to stick to this scheme and not spread those knobs back in the tree. [1] http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk#rev1.44 Thanks. Regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080608075256.GA35560>