Date: Sun, 2 Mar 2003 12:35:56 -0800 From: "Maksim Yevmenkin" <Maksim.Yevmenkin@cw.com> To: "Poul-Henning Kamp" <phk@phk.freebsd.dk>, "Marcel Moolenaar" <marcel@xcllnt.net> Cc: <current@FreeBSD.ORG> Subject: RE: HEADSUP: Driver mega-commit ahead. Message-ID: <45258A4365C6B24A9832BFE224837D552B1296@sjdcex01.int.exodus.net>
next in thread | raw e-mail | index | archive | help
Dear Poul-Henning,
i think the following is not correct
RCS file: /home/ncvs/src/sys/netgraph/ng_device.c,v
retrieving revision 1.2
diff -u -r1.2 ng_device.c
--- netgraph/ng_device.c 2 Feb 2003 13:30:00 -0000 1.2
+++ netgraph/ng_device.c 2 Mar 2003 19:48:38 -0000
@@ -66,7 +66,7 @@
/* Netgraph type */
static struct ng_type typestruct =3D {
NG_ABI_VERSION, /* version */
- NG_DEVICE_NODE_TYPE, /* name */
+ .d_name =3D NG_DEVICE_NODE_TYPE,
ng_device_mod_event, /* modevent */
ng_device_cons, /* constructor */
ng_device_rcvmsg, /* receive msg */
@@ -114,19 +114,14 @@
please fix
thanks
max
-----Original Message-----
From: Poul-Henning Kamp [mailto:phk@phk.freebsd.dk]
Sent: Sun 3/2/2003 12:26 PM
To: Marcel Moolenaar
Cc: current@FreeBSD.ORG
Subject: Re: HEADSUP: Driver mega-commit ahead.=20
In message <20030302202015.GA546@athlon.pn.xcllnt.net>, Marcel Moolenaar =
writes
:
>On Sun, Mar 02, 2003 at 09:14:13PM +0100, Poul-Henning Kamp wrote:
>>=20
>> I plan to commit
>> http://phk.freebsd.dk/patch/cdevsw.patch
>> one of the first days of the week.
>>=20
>> Basically, it changes cdevsw initializations to use C99 sparse
>> format, and thereby eliminates 859 lines of redundant defaultvalue
>> initializations.
>
>I thought HEAD was in a slush mode. des' sweep and this sweep seems
>like the kind of changes we don't want at this time. Has this changed
>or did re@ approve it (both cases)?
I can't talk for DES sweep, (although I'll say that it seems like
a step in the right direction for me).
This particular sweep gives os much better cross-branch source
portability and therefore I think it is exactly the kind of thing
we want before the RELENG_5 branch.
--=20
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe =20
Never attribute to malice what can adequately be explained by =
incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45258A4365C6B24A9832BFE224837D552B1296>