Date: Thu, 13 Dec 2012 09:01:25 -0800 From: mdf@FreeBSD.org To: Andriy Gapon <avg@freebsd.org> Cc: Adrian Chadd <adrian@freebsd.org>, Alfred Perlstein <alfred@freebsd.org>, John Baldwin <jhb@freebsd.org>, svn-src-all@freebsd.org, Alfred Perlstein <bright@mu.org>, src-committers@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r244112 - head/sys/kern Message-ID: <CAMBSHm_z97SDt4igHtirB=wA2tbFYT%2B2uwCLGrOhspJOE_OcfQ@mail.gmail.com> In-Reply-To: <50C9A321.5060407@FreeBSD.org> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <CAJ-Vmo=U04GX%2BZyKuzXLwV%2BPpzU6_dm5BCmL=DWfsmhTVAR%2BsA@mail.gmail.com> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <50C909BD.9090709@mu.org> <50C97D94.1090603@FreeBSD.org> <CAJ-Vmo=Fh=UEcg8oXraU1C8_2T2pQW7SoSP=bpGCyGcSb6hmjQ@mail.gmail.com> <50C97F8D.6010504@FreeBSD.org> <CAJ-Vmo=4S7wyoa2k6P3Cf2T1ToEwoTf0BcGbb3dnFF2qst4Fwg@mail.gmail.com> <50C9A321.5060407@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 13, 2012 at 1:42 AM, Andriy Gapon <avg@freebsd.org> wrote: > on 13/12/2012 09:16 Adrian Chadd said the following: >> Hi, >> >> I think the fundamental problem here is we have some pretty different >> ideas of what KASSERT should be, versus what it actually is in various >> parts of the code. > > Oh, and another part of the problem is that the discussion is opinion based. > But it didn't have to be. > > Compare this: > We think that feature F is a very good idea, we think that it will be used by many > people and it will provide a lot of benefits. So here you are - the code is in > the tree. > > To this: > We have been using feature F, it has proved to be a very good idea as it provided > these benefits and spared us from these problems. So here you are - the code is > in the tree. > > If I have a differing opinion in the first case I usually state it (and can be > pulled into an argument about it). If I have a different opinion in the second > case, I try to adjust my opinion to the stated reality. > >> Since we're lost in semantics, we're not going to get any further on >> this discussion just for now, so let's take a break and think about >> other things for now. Tools, not policy. A non-panic-ing KASSERT is a tool, not enabled by default. You don't need to use it. Someone does, so why can't we provide the tool? Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMBSHm_z97SDt4igHtirB=wA2tbFYT%2B2uwCLGrOhspJOE_OcfQ>