Date: Wed, 14 Jan 2026 08:38:27 -0700 From: Warner Losh <imp@bsdimp.com> To: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= <des@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7f8b4db9e001 - main - github: Add more context to pull requests Message-ID: <CANCZdfoMFRQQddkptdrrWvYxbuDpnvHYDYKFKYD3AnJqS-iu2Q@mail.gmail.com> In-Reply-To: <86jyxkfeo9.fsf@ltc.des.dev> References: <6964a4b0.3d7cb.74aa5260@gitrepo.freebsd.org> <6e64a14f-1fa0-45ec-b73b-e84f1dbb8153@FreeBSD.org> <CANCZdfofLubYy5%2BWonHRjBodg-u94-FGZft4k0mH6emtcW1Jzw@mail.gmail.com> <86jyxkfeo9.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jan 14, 2026 at 7:32 AM Dag-Erling Smørgrav <des@freebsd.org> wrote: > Warner Losh <imp@bsdimp.com> writes: > > John Baldwin <jhb@freebsd.org> writes: > > > sys/crypto isn't really the same. We store the generated OpenSSL > > > assembly files there for use by ossl(4), but most of sys/crypto is > > > not vendored (e.g. ccp, the non-assembly ossl bits, aesni are all > > > just bespoke). > > That's the beauty of this: We can have whatever we want here... These > > were placeholders until we had more nuanced things. I see things like > > openssh in crypto too, so many things are vendored there, in addition > > to the mire of inconsistency... > > crypto is nearly fully vendored, sys/crypto is mostly not, don't confuse > the two... > Sure. So what's the actionable suggestion? Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Jan 14, 2026 at 7:32 AM Dag-Erling Smørgrav <<a href="mailto:des@freebsd.org">des@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Warner Losh <<a href="mailto:imp@bsdimp.com" target="_blank">imp@bsdimp.com</a>> writes:<br> > John Baldwin <<a href="mailto:jhb@freebsd.org" target="_blank">jhb@freebsd.org</a>> writes:<br> > > sys/crypto isn't really the same. We store the generated OpenSSL<br> > > assembly files there for use by ossl(4), but most of sys/crypto is<br> > > not vendored (e.g. ccp, the non-assembly ossl bits, aesni are all<br> > > just bespoke).<br> > That's the beauty of this: We can have whatever we want here... These<br> > were placeholders until we had more nuanced things. I see things like<br> > openssh in crypto too, so many things are vendored there, in addition<br> > to the mire of inconsistency...<br> <br> crypto is nearly fully vendored, sys/crypto is mostly not, don't confuse<br> the two...<br></blockquote><div><br></div><div>Sure. So what's the actionable suggestion?</div><div><br></div><div>Warner</div></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoMFRQQddkptdrrWvYxbuDpnvHYDYKFKYD3AnJqS-iu2Q>