Date: Sat, 15 May 2021 23:14:31 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Lutz Donnerhacke <lutz@donnerhacke.de> Cc: Lutz Donnerhacke <donner@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: effc8e57fbf0 - main - libalias: Style cleanup Message-ID: <YKArpyRTTAah4LSG@kib.kiev.ua> In-Reply-To: <20210515195812.GB17734@belenus.iks-jena.de> References: <202105150701.14F717lf084359@gitrepo.freebsd.org> <YKAkAcYHXN7XMyoL@kib.kiev.ua> <20210515195812.GB17734@belenus.iks-jena.de>
index | next in thread | previous in thread | raw e-mail
On Sat, May 15, 2021 at 09:58:12PM +0200, Lutz Donnerhacke wrote:
> On Sat, May 15, 2021 at 10:41:53PM +0300, Konstantin Belousov wrote:
> > On Sat, May 15, 2021 at 07:01:07AM +0000, Lutz Donnerhacke wrote:
> > > @@ -285,21 +283,20 @@ static int UdpAliasOut(struct libalias *, struct ip *, int, int create);
> > > static int TcpAliasIn(struct libalias *, struct ip *);
> > > static int TcpAliasOut(struct libalias *, struct ip *, int, int create);
> > >
> > > -static int
> > > -IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > > -{
> > > -
> > > - LIBALIAS_LOCK_ASSERT(la);
> > > /*
> > > De-alias incoming echo and timestamp replies.
> > > Alias incoming echo and timestamp requests.
> > > */
> > > +static int
> > > +IcmpAliasIn1(struct libalias *la, struct ip *pip)
> > > +{
> > > + LIBALIAS_LOCK_ASSERT(la);
> > > struct alias_link *lnk;
> > > struct icmp *ic;
> > And this is not in style. Declarations must precede executable statements,
> > even asserts.
>
> Of course it was a style commit.
>
> + /*
> + De-alias incoming echo and timestamp replies.
> + Alias incoming echo and timestamp requests.
> + */
> static int
> IcmpAliasIn1(struct libalias *la, struct ip *pip)
> {
> -
> LIBALIAS_LOCK_ASSERT(la);
> - /*
> - De-alias incoming echo and timestamp replies.
> - Alias incoming echo and timestamp requests.
> - */
> struct alias_link *lnk;
I do not understand what are you trying to say.
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YKArpyRTTAah4LSG>