Date: Wed, 15 Nov 2023 14:59:46 -0700 From: Warner Losh <imp@bsdimp.com> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: 3fd60a6b73ac - main - awk: Merge upstream 2nd Edition Awk Book Message-ID: <CANCZdfq6tWv9skfuA2DAo6AEhJGgFJzVzdWTx3pW8eMaSk-GpQ@mail.gmail.com> In-Reply-To: <C3D101D8-77BB-4250-B934-18C711BADE46@freebsd.org> References: <202311140451.3AE4p5AR014207@gitrepo.freebsd.org> <C3D101D8-77BB-4250-B934-18C711BADE46@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Nov 15, 2023 at 9:52 AM Jessica Clarke <jrtc27@freebsd.org> wrote: > On 14 Nov 2023, at 04:51, Warner Losh <imp@FreeBSD.org> wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3fd60a6b73ac01a72df89751f173970fae4cae73 > > > > commit 3fd60a6b73ac01a72df89751f173970fae4cae73 > > Merge: 194df014feeb 2e406c584fe4 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2023-11-02 16:32:01 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2023-11-14 04:49:34 +0000 > > > > awk: Merge upstream 2nd Edition Awk Book > > > > Merge in the November 2nd, 2023 version of one true awk. > > > > This brings in Unicode support, CSV support and a number of bug fixes. > > > > Sponsored by: Netflix > > Reviewed by: delphij > > Differential Revision: https://reviews.freebsd.org/D42447 > > This seems to have broken the GitHub CI for cross-building; contrast: > > https://github.com/freebsd/freebsd-src/actions/runs/6859373313 > > with: > > https://github.com/freebsd/freebsd-src/actions/runs/6859316228 > > Has this broken makeobjops.awk somehow? If so it should be reproducible > on FreeBSD with BOOTSTRAP_ALL_TOOLS=1, or by rebuilding on an updated > system. Cross-building will just show it first because we always > bootstrap awk there, like many other tools. > It worked when it was the system awk for me... But that might not be the most helpful observation. Why didn't it work for you/github's ci runs? makeobjops.awk doesn't have any of the issues that I know are minor changes in awk. I'll add it to the list of things to look into, though. I also broke the Jenkins CI run, but not 'make check' for reasons I don't understand. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 15, 2023 at 9:52 AM Jessica Clarke <<a href="mailto:jrtc27@freebsd.org">jrtc27@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 14 Nov 2023, at 04:51, Warner Losh <imp@FreeBSD.org> wrote:<br> > <br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=3fd60a6b73ac01a72df89751f173970fae4cae73" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=3fd60a6b73ac01a72df89751f173970fae4cae73</a><br>; > <br> > commit 3fd60a6b73ac01a72df89751f173970fae4cae73<br> > Merge: 194df014feeb 2e406c584fe4<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2023-11-02 16:32:01 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2023-11-14 04:49:34 +0000<br> > <br> > awk: Merge upstream 2nd Edition Awk Book<br> > <br> > Merge in the November 2nd, 2023 version of one true awk.<br> > <br> > This brings in Unicode support, CSV support and a number of bug fixes.<br> > <br> > Sponsored by: Netflix<br> > Reviewed by: delphij<br> > Differential Revision: <a href="https://reviews.freebsd.org/D42447" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D42447</a><br>; <br> This seems to have broken the GitHub CI for cross-building; contrast:<br> <br> <a href="https://github.com/freebsd/freebsd-src/actions/runs/6859373313" rel="noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/actions/runs/6859373313</a><br>; <br> with:<br> <br> <a href="https://github.com/freebsd/freebsd-src/actions/runs/6859316228" rel="noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/actions/runs/6859316228</a><br>; <br> Has this broken makeobjops.awk somehow? If so it should be reproducible<br> on FreeBSD with BOOTSTRAP_ALL_TOOLS=1, or by rebuilding on an updated<br> system. Cross-building will just show it first because we always<br> bootstrap awk there, like many other tools.<br></blockquote><div><br></div><div>It worked when it was the system awk for me... But that might not be the most</div><div>helpful observation. Why didn't it work for you/github's ci runs?</div><div><br></div><div>makeobjops.awk doesn't have any of the issues that I know are minor changes</div><div>in awk. I'll add it to the list of things to look into, though.</div><div><br></div><div>I also broke the Jenkins CI run, but not 'make check' for reasons I don't</div><div>understand.</div><div><br></div><div>Warner</div><div><br></div><div><br></div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq6tWv9skfuA2DAo6AEhJGgFJzVzdWTx3pW8eMaSk-GpQ>