Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Sep 2021 03:22:22 +0000
From:      bugzilla-noreply@freebsd.org
To:        python@FreeBSD.org
Subject:   [Bug 258593] [NEW] sysutils/py-puremagic: Pure python implementation of magic file detection
Message-ID:  <bug-258593-21822-NJ1tCiFF6W@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-258593-21822@https.bugs.freebsd.org/bugzilla/>
References:  <bug-258593-21822@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258593

--- Comment #3 from James French <james@french.id.au> ---
Thanks for the review Kubilay, I'm working on an update that will address t=
hose
issues and should have it back later today.

Just on the test suite, the python code for the tests is distributed with t=
he
source but the data files they depend on is not (presumably because it's qu=
ite
a large set of data). The test suite will always fail from a PyPi tarball, =
even
if the code is fine.

I can cobble something together that sources those files from GitHub to make
the test suite work but it may overcomplicate the port. Not sure if this is
something we should do or not.

In either case, I will probably submit two patches one with and one without
fetching that data.

Cheers,
James

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258593-21822-NJ1tCiFF6W>