Date: Tue, 17 Dec 2019 20:14:35 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Hans Petter Selasky <hps@selasky.org>, Slava Shwartsman <slavash@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en Message-ID: <60698d75-ca26-da71-682c-ec7d24f0eab6@yandex.ru> In-Reply-To: <6151923d-05bb-b945-359e-d632708ba021@selasky.org> References: <201812051420.wB5EKwxr099242@repo.freebsd.org> <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> <6151923d-05bb-b945-359e-d632708ba021@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7 Content-Type: multipart/mixed; boundary="YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc"; protected-headers="v1" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Hans Petter Selasky <hps@selasky.org>, Slava Shwartsman <slavash@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <60698d75-ca26-da71-682c-ec7d24f0eab6@yandex.ru> Subject: Re: svn commit: r341578 - head/sys/dev/mlx5/mlx5_en References: <201812051420.wB5EKwxr099242@repo.freebsd.org> <8715aa7b-ceea-7cfd-1980-a260c98070d5@yandex.ru> <6151923d-05bb-b945-359e-d632708ba021@selasky.org> In-Reply-To: <6151923d-05bb-b945-359e-d632708ba021@selasky.org> --YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 13.12.2019 17:27, Hans Petter Selasky wrote: > On 2019-12-13 14:40, Andrey V. Elsukov wrote: >> On 05.12.2018 17:20, Slava Shwartsman wrote: >>> Author: slavash >>> Date: Wed Dec=C2=A0 5 14:20:57 2018 >>> New Revision: 341578 >>> URL: https://svnweb.freebsd.org/changeset/base/341578 >>> >>> Log: >>> =C2=A0=C2=A0 mlx5en: Remove the DRBR and associated logic in the tran= smit path. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 The hardware queues are deep enough current= ly and using the >>> DRBR and associated >>> =C2=A0=C2=A0 callbacks only leads to more task switching in the TX pa= th. The is >>> also a race >>> =C2=A0=C2=A0 setting the queue_state which can lead to hung TX rings.= >> >> JFYI. We have compared the same router+firewall workloads on the host >> with this change and before, and I can say, that without DRBR on TX no= w >> we constantly have several percents of packets drops due to ENOBUFS >> error from mlx5e_xmit(). >> >=20 > Have you tried to tune the TX/RX parameters? >=20 > Especially the tx_queue_size . We use the following settings: % sysctl dev.mce.4.conf. | grep que dev.mce.4.conf.rx_queue_size: 16384 dev.mce.4.conf.tx_queue_size: 16384 dev.mce.4.conf.rx_queue_size_max: 16384 dev.mce.4.conf.tx_queue_size_max: 16384 Also, previously I have patched MLX5E_SQ_TX_QUEUE_SIZE value up to 16384.= --=20 WBR, Andrey V. Elsukov --YAMnh3pzM1iWcSxXeJlDRplnwIdZABgpc-- --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAl35DPsACgkQAcXqBBDI oXpjAAgAjWJhnrYCqMijx0rsjTxwwVfVGImL4JpYARwEJ8TKNk/5tYyH8WNb9LrS GQoE0dSoalxgSc5m7hV/LlX1qi188h2j3+FljiekU0It8RiIWAzvIMp9xpFwDpi4 nZ5O9ppAJ+O3XFOV9K4P3R/5l4mPy9AVAmYDnk9qMKGfk7L/Pej8fFq/h0s3Vo9o Zq67OGTRkfqRQLUiMRfrIo+mM46NWAW6Z/8Wo1Gu23mkOif4DIUP0HeJLyU+/nl/ 1WtD3NGprsN1IXqF7D32L7HAeTfvF8GF9TOTNm3QIi+vhZQtwL0grG+cxjcVHIU3 arCa/iuWJkbZJcPucTv+yczzQDXsGg== =DBXn -----END PGP SIGNATURE----- --C3uohgIZIngDLk3qugCqJrUeptLYnHMh7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?60698d75-ca26-da71-682c-ec7d24f0eab6>