Date: Wed, 30 Nov 2016 13:40:51 -0700 From: Ian Lepore <ian@freebsd.org> To: Jakub Klama <jakub@ixsystems.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309121 - head/usr.sbin/bhyve Message-ID: <1480538451.1889.187.camel@freebsd.org> In-Reply-To: <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com> References: <201611242216.uAOMGIi0065703@repo.freebsd.org> <1480026232.1889.63.camel@freebsd.org> <7F692FF4-4F36-4ED8-AF26-4684D41CB3AE@ixsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2016-11-24 at 23:27 +0100, Jakub Klama wrote: > > > > Wiadomość napisana przez Ian Lepore <ian@FreeBSD.org> w dniu > > 24.11.2016, o godz. 23:23: > > > > On Thu, 2016-11-24 at 22:16 +0000, Jakub Wojciech Klama wrote: > > > > > > Author: jceel > > > Date: Thu Nov 24 22:16:18 2016 > > > New Revision: 309121 > > > URL: https://svnweb.freebsd.org/changeset/base/309121 > > > > > > Log: > > > virtio_console: handle short writes to an Unix domain socket > > > gracefully. > > > > > > writev() can do a short write. Retrying it results in a very > > > convoluted > > > and complex code, so we iterate over iovec and do regular > > > stream_write() > > > instead. > > > > > Doesn't pwritev(2) simplify iterating to handle short writes? > > > Correct me if I'm wrong, but pwritev(2) is a writev(2) with offset. > We're writing to an Unix domain socket here, which is not seekable. > > Thanks, > Jakub > > My bad, I was under the impression the offset was an offset into the iovec, not into the file. So, ummm... nevermind. :) -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1480538451.1889.187.camel>