Date: Wed, 29 Mar 2006 09:41:18 +0800 From: David Xu <davidxu@freebsd.org> To: Daniel Eischen <deischen@freebsd.org> Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, Alexander Kabaev <kabaev@gmail.com>, Dag-Erling Smorgrav <des@freebsd.org> Subject: Re: cvs commit: src/libexec/rtld-elf/i386 rtld_machdep.h Message-ID: <4429E5BE.7070700@freebsd.org> In-Reply-To: <Pine.GSO.4.43.0603282025220.18701-100000@sea.ntplx.net>
index | next in thread | previous in thread | raw e-mail
Daniel Eischen wrote: > On Tue, 28 Mar 2006, Alexander Kabaev wrote: > > >>On Tue, 28 Mar 2006 18:28:07 +0000 (UTC) >>Dag-Erling Smorgrav <des@FreeBSD.org> wrote: >> >> >>>des 2006-03-28 18:28:07 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> libexec/rtld-elf/i386 rtld_machdep.h >>> Log: >>> Don't use dbg if it isn't defined (such as when this file is used by >>> code outside of rtld-elf) >>> >>> Revision Changes Path >>> 1.11 +2 -0 src/libexec/rtld-elf/i386/rtld_machdep.h >>> >>>http://cvsweb.FreeBSD.org/src/libexec/rtld-elf/i386/rtld_machdep.h.diff?r1=1.10&r2=1.11 >> >>The use of this file in threading libraries is illegal and should be >>fixed instead. > > > David Xu probably knows more about this, but it's needed for > the debugger. rtld.h is included by the thread libraries, > so rtld_machdep.h comes along for the ride. > It is being used to calculate TLS address for debugger, either thread libraries or libthread_db have to use it, it is not important who is using it, fixing it in rtld header files is needed. David Xuhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4429E5BE.7070700>