Date: Sun, 30 Jul 2006 12:30:45 -0700 From: "Kip Macy" <kip.macy@gmail.com> To: "Tijl Coosemans" <tijl@ulyssis.org> Cc: freebsd-hackers@freebsd.org Subject: Re: i386 page fault clobbers error code in trap frame Message-ID: <b1fa29170607301230u65548684ud25d77e0ff0bfb96@mail.gmail.com> In-Reply-To: <200607301834.16657.tijl@ulyssis.org> References: <200607292110.37733.tijl@ulyssis.org> <b1fa29170607291257h43592826j75513b465074f115@mail.gmail.com> <200607301834.16657.tijl@ulyssis.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > si_addr doesn't contain the faulting pc, it contains the address that So either the comment is wrong, or that is a technically incorrect kludge. However, given that a number of the other fields are not filled out at all, the real objective should be to keep applications working. > > --- sys/i386/i386/trap.c.orig Sun Jul 30 18:27:21 2006 > +++ sys/i386/i386/trap.c Sun Jul 30 18:27:56 2006 > @@ -777,9 +777,6 @@ > return (-1); > } > > - /* kludge to pass faulting virtual address to sendsig */ > - frame->tf_err = eva; > - > return((rv == KERN_PROTECTION_FAILURE) ? SIGBUS : SIGSEGV); > } > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b1fa29170607301230u65548684ud25d77e0ff0bfb96>