Date: Wed, 03 Oct 2012 17:24:39 -0600 From: Peter Grehan <grehan@freebsd.org> To: Peter Jeremy <peter@rulingia.com> Cc: svn-src-projects@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r241153 - in projects/bhyve/sys/boot: common userboot/userboot Message-ID: <506CC937.2010409@freebsd.org> In-Reply-To: <20121003225011.GA61464@vps.rulingia.com> References: <201210030422.q934Mdt0060521@svn.freebsd.org> <20121003225011.GA61464@vps.rulingia.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Peter, > IMHO, the comment here is somewhat confusing Agreed. > Can I suggest an alternate comment along the lines of: > /* > * (Maximum?) Dictionary size in cells. Note that the default FICL dictionary > * requires ~4000 cells. > */ The irony is that FICL_DEFAULT_DICT, used if the passed in param to ficlInitSystem() is <=0, is actually 12288 on all arches. How about if I just remove the '~4000 cells' text, and maybe put in something like * FreeBSD loader default dictionary cells The irony is that FICL_DEFAULT_DICT, used if the passed in param to ficlInitSystem() is <=0, is actually 12288 on all arches. later, Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?506CC937.2010409>