Date: Wed, 21 Oct 2015 17:14:28 -0600 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@FreeBSD.org> Cc: "freebsd-arch@freebsd.org" <arch@FreeBSD.org> Subject: Re: svn commit: r289710 - in head/sys/modules: i2c/iicbb uart Message-ID: <79E318B6-4556-4323-9D40-14269B470DA4@bsdimp.com> In-Reply-To: <CAPyFy2AkYKWAQiYdT5V_MNA1GtGrM58r=xrubYku0JyQ79%2BHdQ@mail.gmail.com> References: <201510211830.t9LIUgWt061526@repo.freebsd.org> <CAPyFy2AkYKWAQiYdT5V_MNA1GtGrM58r=xrubYku0JyQ79%2BHdQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 21, 2015, at 1:16 PM, Ed Maste <emaste@FreeBSD.org> wrote: >=20 > On 21 October 2015 at 14:30, Ed Maste <emaste@freebsd.org> wrote: >> Author: emaste >> Date: Wed Oct 21 18:30:42 2015 >> New Revision: 289710 >> URL: https://svnweb.freebsd.org/changeset/base/289710 >>=20 >> Log: >> Build ofw_bus_if.h for modules that need it on arm64 >=20 > Module Makefile build rules for ofw_bus_if.h are a bit of a mess; some > modules build it unconditionally while others build it only on certain > archs. There are a large number of different combinations of sparc64, > mips, powerpc, arm, and aarch64. This is true for a number of other > arch-specific module Makefile support. Should we have MK_* knobs to > control these cases -- e.g. MK_OFW (MK_FDT?) here? That would at least > move the arch-specific tests to a common location. How much of the swamp do you want to drain? None: Create MK_OFW (not MK_FDT: it already means something else). Add a few lines to src.opts.mk. Watch me complain :) A little: Add DEV_OFW to options. Add DEV_OFW to the relevant KERN_OPTS clauses in sys/conf/config.mk and then test for it like so in the = modules makefiles: .if (${KERN_OPTS:MDEV_OFW}) =E2=80=A6 .endif Maybe add it in config.mk if MK_FDT is defined, but I=E2=80=99d prefer = not That=E2=80=99s what we=E2=80=99re really testing for here: is this = kernel likely to have the OFW routines being called. A lot: rewrite config(8). I=E2=80=99m hoping you=E2=80=99ll pick =E2=80=9Ca little=E2=80=9D to not = make things worse. Warner --Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJWKBxVAAoJEGwc0Sh9sBEAZ5UQANDuxcf5AoPIciDP7hKJk4In RclltBr7lkydMzjIfJJpBhZ5OF4OYpK79EcsTeuuqs0iXZYUwG/VS4TW1wL1M4jk kKhgR566o/Uh8g54//GTf+vk3+pik/x5yfno9IyR+I5h68rtQWncKN9ABq5PITTM FQVpS7yUc3/Rc/DpJJzEeKawcap1yPBShHsKdNgSRJRaVL5P5f2G6lm/xi+OyPtR aL57u+Lzp6AYAgSEfo/cu0rVE0q+tOnDUmt7alum1cz/HRO09ZYmhSgf+3RGeGs5 QLFoyZABYX1QECl9P3wSVV9Pr7Z9nBog06CZLubG0S4aFLDXmsZzMgeVO1ccgczQ mwF2tybWH6+qqkaU2ERO3Pg12uDG3Sd1jaz5u8w2bFNJmepNhlsL9aVojegRrEy5 6SrgqR9npxRD1Ywha0QxWG6s0bnvwZ5nPL/NNlfvNYjDCwACvfJvp0lYAFpFiH9z vEu0obksO+jkIvBNsgaATgqhYNKgGcNnsvNTQRUh8Lty/cWcC/+gYMSr8a3bhhe7 0pocUIJPNLBD7rarPr0W/FsJQqLByGX2+Fo36nuGgFHjnvktjjOFsS1SZrgrHsFx A/pTYLm6JvHLU9NQn+o8wz5ETTpZArMQz5sK1GrSK2nVcdwklWf92CLgw/ukjmby yiv6/8pi1pLNGEaE+87d =uHEi -----END PGP SIGNATURE----- --Apple-Mail=_282D0F5B-E85D-4B56-8E6F-CCC73F5B3C80--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?79E318B6-4556-4323-9D40-14269B470DA4>