Date: Mon, 8 Apr 2002 17:04:01 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: "David E. O'Brien" <obrien@FreeBSD.org>, Bruce Evans <bde@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/gnu/usr.bin/cc/cc1 Makefile src/gnu/usr.bin/cc/cc1obj Makefile src/gnu/usr.bin/cc/cc1plus Makefile Message-ID: <20020408165120.S5876-100000@gamplex.bde.org> In-Reply-To: <20020407162550.GE67968@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 7 Apr 2002, Ruslan Ermilov wrote: > On Wed, Apr 03, 2002 at 04:50:14PM -0800, David E. O'Brien wrote: > > obrien 2002/04/03 16:50:14 PST > > > > Modified files: > > gnu/usr.bin/cc/cc1 Makefile > > gnu/usr.bin/cc/cc1obj Makefile > > gnu/usr.bin/cc/cc1plus Makefile > > Log: > > Set NOSHARED conditionally. > > > Why? Conditionally setting NOSHARED only makes sense in Makefile.inc > where it may be overridden by individual makefiles beneath it. > (Seeing if Bruce agrees.) I've already objected to this commit for almost the opposite reason. It makes sense to set some `make' variables conditionally, and NOSHARED is one of these. Users can set it before the Makefile is invoked, and NOSHARED?= is used in most places to avoid clobbering such earlier settings. However, in the special case of the large first passes of cc, we (people who set NOSHARED here previously) think that clobbering earlier settings is right, because the space savings are small and the time savings are large for using NOSHARED unconditionally. This is not very well documented. The only hint of it in the logs is "appropriately" in rev.1.12 of cc1/Makefile, etc. Setting NOSHARED conditionally was considered to be appropriate [almost?] everywhere except in the above Makefiles. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020408165120.S5876-100000>