Date: Thu, 27 Feb 1997 14:29:03 +0100 From: Eivind Eklund <eivind@dimaga.com> To: Brian Somers <brian@awfulhak.demon.co.uk> Cc: hackers@freebsd.org, eivind@freebsd.org, bde@zeta.org.au, brian@utell.co.uk Subject: Re: Include files (in ppp) Message-ID: <3.0.32.19970227142902.00bccd30@dimaga.com>
next in thread | raw e-mail | index | archive | help
At 01:23 AM 2/27/97 +0000, Brian Somers wrote: >I'd suggest one of the following: > >- Leave it as it is (with osreldate.h adding partially to the chaos) >- Remove all of the #ifs buts and whys (rationalle: If osreldate isn't > in there, All the #if BSD etc stuff is useless anyway) I'd say this depend on a few things: (A) How many patches to IIJ-PPP do we recieve? If there are a lot of these, removing #ifdefs might disrupt merging. (Doesn't look like it from the amount of commits, though.) (B) Is IIJ-PPP actively developed anywhere outside FreeBSD? See (A). (PPP+pktAlias doesn't count - I'll merge any changes from -current) (C) Is IIJ-PPP from FreeBSD actively used by non-FreeBSD people? In this case, we could pay them the courtesy of leaving it in. If none of these factors give us trouble, I'd say we cut the #ifdef's - they clutter the code. However, the final choice is in Brian's hands - as well as the responsibility for adding himself as maintainer in the Makefile ;-) Eivind Eklund perhaps@yes.no http://maybe.yes.no/perhaps/ eivind@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3.0.32.19970227142902.00bccd30>