Date: Thu, 10 May 2012 12:03:53 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Kohji Okuno <okuno.kohji@jp.panasonic.com> Cc: freebsd-current@freebsd.org, David Chisnall <theraven@FreeBSD.org> Subject: Re: The current libc/locale/toupper.c is mistaken Message-ID: <4FAB9289.8060808@FreeBSD.org> In-Reply-To: <20120510.180247.93202495593231609.okuno.kohji@jp.panasonic.com> References: <20120510.180247.93202495593231609.okuno.kohji@jp.panasonic.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2012-05-10 11:02, Kohji Okuno wrote:
> I think that libc/locale/toupper.c is mistaken.
> Could you check it?
>
> @@ -51,7 +51,7 @@ ___toupper_l(c, l)
> {
> size_t lim;
> FIX_LOCALE(l);
> - _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext;
> + _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__mapupper_ext;
> _RuneEntry *base, *re;
>
> if (c < 0 || c == EOF)
Yes, this definitely looks like a copy/paste error, introduced here:
http://svnweb.freebsd.org/base/head/lib/libc/locale/toupper.c?r1=165903&r2=227753
I'll commit the fix tonight (CEST), if David isn't faster than me. :)
Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FAB9289.8060808>