Date: Sat, 9 Apr 2016 21:29:57 +0100 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: John Baldwin <jhb@FreeBSD.org>, svn-src-head@freebsd.org Subject: Re: svn commit: r297762 - head/sys/dev/ichiic Message-ID: <57096645.5060105@multiplay.co.uk> In-Reply-To: <201604092018.u39KIYf3096159@repo.freebsd.org> References: <201604092018.u39KIYf3096159@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi John, it would be nice if the commit message clarified why the change was made, as well as what was changed. This would allow others like myself to learn about the reasons for changes like this, which aren't self explanatory. On 09/04/2016 21:18, John Baldwin wrote: > Author: jhb > Date: Sat Apr 9 20:18:34 2016 > New Revision: 297762 > URL: https://svnweb.freebsd.org/changeset/base/297762 > > Log: > Use DELAY() instead of sleeping during boot-time attach. > > Tested by: Wolfgang Zenker <wolfgang@lyxys.ka.sub.org> > > Modified: > head/sys/dev/ichiic/ig4_iic.c > > Modified: head/sys/dev/ichiic/ig4_iic.c > ============================================================================== > --- head/sys/dev/ichiic/ig4_iic.c Sat Apr 9 20:05:39 2016 (r297761) > +++ head/sys/dev/ichiic/ig4_iic.c Sat Apr 9 20:18:34 2016 (r297762) > @@ -117,7 +117,10 @@ set_controller(ig4iic_softc_t *sc, uint3 > error = 0; > break; > } > - mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > + if (cold) > + DELAY(1000); > + else > + mtx_sleep(sc, &sc->io_lock, 0, "i2cslv", 1); > } > return (error); > } >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57096645.5060105>