Date: Sat, 15 Aug 2020 22:04:58 +0200 (CEST) From: Wojciech Puchar <wojtek@puchar.net> To: Mark Johnston <markj@freebsd.org> Cc: Wojciech Puchar <wojtek@puchar.net>, freebsd-hackers@freebsd.org Subject: Re: gmirror balance model "prefer" doesnt work properly Message-ID: <alpine.BSF.2.20.2008152204200.81858@puchar.net> In-Reply-To: <20200815165438.GA41502@raichu> References: <alpine.BSF.2.20.2008151127420.18876@puchar.net> <20200815165438.GA41502@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
>> LIST_FOREACH(disk, &sc->sc_disks, d_next) {
>> if (disk->d_state == G_MIRROR_DISK_STATE_ACTIVE)
>> break;
>> }
>>
>>
>> just take first active disk.
>>
>> why?
>
> The highest priority disk is supposed to be first in the list. However,
> the list is only sorted once the mirror is started, which is arguably
But is "higher priority" higher or lower number?
> the bug. If you restart the mirror after adjusting the disk priorities,
> I'd expect the "prefer" algorithm to work properly.
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.20.2008152204200.81858>