Date: Thu, 25 Dec 2014 10:01:31 -0800 From: Alfred Perlstein <bright@mu.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Marcel Moolenaar <marcel@freebsd.org>, Phil Shafer <phil@juniper.net>, John-Mark Gurney <jmg@funkthat.com>, Alfred Perlstein <alfred@freebsd.org>, "arch@freebsd.org" <arch@freebsd.org>, Poul-Henning Kamp <phk@phk.freebsd.dk>, freebsd-arch <freebsd-arch@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Subject: Re: Libxo bugs and fixes. Message-ID: <549C50FB.6050908@mu.org> In-Reply-To: <18276.1419528679@chaos> References: <201408141640.s7EGe422096656@idle.juniper.net> <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net> <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net> <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net> <549BA675.9070107@freebsd.org> <29784.1419492726@chaos> <26E73A9E-6EA4-4698-885D-BD91906D32D2@mu.org> <18276.1419528679@chaos>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/25/14 9:31 AM, Simon J. Gerraty wrote: > Alfred Perlstein <bright@mu.org> wrote: >> Yes, the patch leaves it to the caller. The otherwise when you run "netstat --libxo json 1" you only see output every BUFSIZE bytes from netstat. > I was refering to the call to xo_flush in xo_emit. > The application best knows what are suitable points at which to flush > its output. > If you eliminate that call, it might be ok > I don't think my patch adds an xo_flush to xo_emit... ? Did I miss something? Yes, there is an explicit flush at the end of xo_message_hcv() but that should be harmless or possibly removed since the output channel for warnings should be unbuffered. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?549C50FB.6050908>