Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Oct 2008 10:03:26 +0200
From:      Ed Schouten <ed@80386.nl>
To:        current@freebsd.org
Subject:   Re: [head tinderbox] failure on i386/i386
Message-ID:  <20081022080326.GH16837@hoeg.nl>
In-Reply-To: <20081021210023.0CE4373039@freebsd-current.sentex.ca>
References:  <20081021210023.0CE4373039@freebsd-current.sentex.ca>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
* FreeBSD Tinderbox <tinderbox@freebsd.org> wrote:
> cc1: warnings being treated as errors
> /src/sys/dev/ppbus/lpt.c: In function 'lpt_attach':
> /src/sys/dev/ppbus/lpt.c:402: warning: assignment makes pointer from integer without a cast
> /src/sys/dev/ppbus/lpt.c: In function 'lptopen':
> /src/sys/dev/ppbus/lpt.c:479: warning: assignment makes integer from pointer without a cast

What about this?

%%%
--- sys/dev/ppbus/lpt.c
+++ sys/dev/ppbus/lpt.c
@@ -392,14 +392,12 @@
 	lpt_release_ppbus(dev);
 
 	sc->dev = dev;
-	sc->cdev = make_dev(&lpt_cdevsw, unit,
+	sc->cdev = make_dev(&lpt_cdevsw, 0,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d", unit);
 	sc->cdev->si_drv1 = sc;
-	sc->cdev->si_drv2 = 0;
-	sc->cdev_bypass = make_dev(&lpt_cdevsw, unit,
+	sc->cdev_bypass = make_dev(&lpt_cdevsw, LP_BYPASS,
 	    UID_ROOT, GID_WHEEL, 0600, LPT_NAME "%d.ctl", unit);
 	sc->cdev_bypass->si_drv1 = sc;
-	sc->cdev_bypass->si_drv2 = LP_BYPASS;
 	return (0);
 }
 
@@ -476,7 +474,7 @@
 	} else
 		sc->sc_state |= LPTINIT;
 
-	sc->sc_flags = dev->si_drv2;
+	sc->sc_flags = dev2unit(dev);
 
 	/* Check for open with BYPASS flag set. */
 	if (sc->sc_flags & LP_BYPASS) {
%%%

-- 
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkj+3k4ACgkQ52SDGA2eCwU42wCeNBJIEqHybsrX0mKoeQ9/ygRF
kVYAnRPo4cGRdo3gHXUQlxqcxc+s3DS1
=VmKF
-----END PGP SIGNATURE-----

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081022080326.GH16837>