Date: Thu, 25 Dec 2014 06:38:12 -0800 From: Alfred Perlstein <bright@mu.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Marcel Moolenaar <marcel@freebsd.org>, Phil Shafer <phil@juniper.net>, John-Mark Gurney <jmg@funkthat.com>, Alfred Perlstein <alfred@freebsd.org>, "arch@freebsd.org" <arch@freebsd.org>, Poul-Henning Kamp <phk@phk.freebsd.dk>, freebsd-arch <freebsd-arch@freebsd.org>, Konstantin Belousov <kostikbel@gmail.com> Subject: Re: Libxo bugs and fixes. Message-ID: <26E73A9E-6EA4-4698-885D-BD91906D32D2@mu.org> In-Reply-To: <29784.1419492726@chaos> References: <201408141640.s7EGe422096656@idle.juniper.net> <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net> <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net> <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net> <549BA675.9070107@freebsd.org> <29784.1419492726@chaos>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Dec 24, 2014, at 11:32 PM, Simon J. Gerraty <sjg@juniper.net> wrote: >=20 > Alfred Perlstein <alfred@freebsd.org> wrote: >> 1) We need libxo to support explicit fflush: >> https://reviews.freebsd.org/D1379 >=20 > This is probably sub-optimal. =20 > Supporting flushing isn't the same thing as blindly doing it. > Probably better if caller can indicate a need for flushing regularly. > Will try and catch up with Phil to discuss. Yes, the patch leaves it to the caller. The otherwise when you run "netstat -= -libxo json 1" you only see output every BUFSIZE bytes from netstat.=20 With the fix I added the xo_flush calls actually work. Which I think is what= you want as well.=20 >=20 >> 2) We need libxo to support time series data. I don't have a patch >> for that, but I would like to ask for ideas on this. This would be >> extremely helpful for instance "netstat 1". would like to get a very >> accurate timestamp with each row. Suggestions on how to do this >> correctly AND *consistently* via libxo would make sense. >>=20 >> 3) I have netstat mostly converted over, however not all the json is >> valid, I will be doing another pass ASAP on this. >> https://reviews.freebsd.org/D1380 >>=20 >> 4) Can I as politely as I know how, ask that Juniper keep the patches >> against the userland utils up to date either in a project branch in >> SVN, or simply in a fork of the github repo? This would make life so >> much easer to deal with. >=20 > I assume that commits would be more use? Yes! Also we should really have unit tests made to make sure the json is valid. I= 've found some bugs and I am fixing them, but it will take some time and I w= ant to avoid regressions.=20 > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26E73A9E-6EA4-4698-885D-BD91906D32D2>